Bring the docker image up to date with the docker-library version #3189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoloRin
force-pushed
the
docker-library-rabbitmq-500
branch
from
d49ce07 to
81ad77e
Compare
michaelklishin
approved these changes
Jul 27, 2021
HoloRin
added a commit
that referenced
this pull request
Jul 28, 2021
Bring the docker image up to date with the docker-library version (cherry picked from commit c8cfd02)
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to docker-library/rabbitmq#501 and also adopts the simplified
docker-entrypoint.shrecently introduced there.I opted to copy the example conf fromdeps/rabbit/docs/rabbitmq.conf.exampleinstead of modifying it in flight. I also considered adding it the*-generic-unix packageso that yet another copy need not exist in thedocker-libraryrepo, however since this is a docker image specific config it did not seem reasonable to include it in the generic-unix archive. Since changes in the docker image currently flow from https://github.com/docker-library/rabbitmq to thepackaging/docker-imagedirectory of this repo, I think it is reasonable that the source of truth for this particular rabbitmq.conf file will be in practice the version in thedocker-libraryrepo.