Adjust initial gen_server_call_timeout #3232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent `amqp_connection:start/2` from logging a warning when we use default values. The default for `connection_timeout` is already 60000. When we don't explicitly set it to a lower value, `amqp_connection:maybe_update_call_timeout/2` adjusts it to 70000 and logs a warning message, which may appear unexpected, especially for users upgrading to 3.8.10+ with no config changes. This change addresses that problem by pre-adjusting it to 70000, making it safe by default and ensuring our default values don't conflict with each other.
michaelklishin
approved these changes
Jul 26, 2021
michaelklishin
added a commit
that referenced
this pull request
Jul 26, 2021
…imeout Adjust initial gen_server_call_timeout (cherry picked from commit 8288bab)
|
Backported to |
michaelklishin
added a commit
that referenced
this pull request
Jul 26, 2021
…imeout Adjust initial gen_server_call_timeout (cherry picked from commit 8288bab)
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Preventing
amqp_connection:start/2from logging a warning when we use default values.The default for
connection_timeoutis already60000. When we don't explicitly set it to a lower value,amqp_connection:maybe_update_call_timeout/2adjusts it to70000and logs a warning message (See #2660), which may appear unexpected, especially for users upgrading to 3.8.10+ with no config changes.This change addresses that problem by pre-adjusting it to
70000, making it safe by default and ensuring our default values don't conflict with each other.Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
An alternative approach to this would be reducing the original
connection_timeoutdefault to50000for example, but that could potentially be a change of bigger impact, since60000has been the default since 1905e30. Please let me know if this is a saner approach and I can make the changes.