rabbit_{connection,channel}_tracking: Fix race condition in list() #3324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table might not exist yet (or is already gone) between the time rabbit_nodes:all_running() runs and returns a specific node, and mnesia:dirty_match_object() is called for that node's table. This seems to happen frequently in CI.
|
If this patch is accepted, I believe it's a good candidate for backport to 3.9.x and 3.8.x. |
michaelklishin
approved these changes
Aug 19, 2021
michaelklishin
deleted the
fix-race-condition-in-connection-channel-tracking-list-function
branch
|
@Mergifyio backport v3.9.x v3.8.x |
This was referenced Aug 19, 2021
|
Command
|
michaelklishin
added a commit
that referenced
this pull request
Aug 19, 2021
rabbit_{connection,channel}_tracking: Fix race condition in list() (backport #3324)
michaelklishin
added a commit
that referenced
this pull request
Aug 19, 2021
rabbit_{connection,channel}_tracking: Fix race condition in list() (backport #3324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table might not exist yet (or is already gone) between the time
rabbit_nodes:all_running()runs and returns a specific node, andmnesia:dirty_match_object()is called for that node's table.This seems to happen frequently in CI.