Revisit two rabbitmq.conf validators #3398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* max_message_size had an off-by-one error and unfortunate naming * classic mirrored queue batch size was not validating the size in messages. The limit of over 2B messages did not make much sense. 1M is a still very high but a more reasonable upper bound Fixes #3390
michaelklishin
added a commit
that referenced
this pull request
Sep 10, 2021
Revisit two rabbitmq.conf validators (backport #3398)
michaelklishin
added a commit
that referenced
this pull request
Sep 10, 2021
Revisit two rabbitmq.conf validators (cherry picked from commit 13ac078)
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limit of over 2B messages did not make much sense. 1M is a still very
high but a more reasonable upper bound
Fixes #3390