Skip to content

Use the deterministic compiler flag for elixir/rabbitmq_cli #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

HoloRin
Copy link
Contributor

@HoloRin HoloRin commented Sep 17, 2021

Proposed Changes

Passes the +deterministic flag to the erlang compiler during elixir compilation. We already use the flag for the rest of the code, so this brings things more in sync.

Note that this only applies to the Bazel build at this point, Make/Erlang.mk are unaffected.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

I intend to address the Make/Erlang.mk side of this in another PR.

@mergify mergify bot added the bazel label Sep 17, 2021
@HoloRin HoloRin merged commit f81afb0 into master Sep 17, 2021
@HoloRin HoloRin deleted the deterministic-compiler-flag-mix branch September 17, 2021 07:28
HoloRin added a commit that referenced this pull request Sep 17, 2021
Use the deterministic compiler flag for elixir/rabbitmq_cli (backport #3440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant