Skip to content

Split the feature_flags_SUITE into two parts for CI/Bazel #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions deps/rabbit/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,19 @@ suites = [
size = "large",
flaky = True,
shard_count = 5,
runtime_deps = [
"//deps/rabbit/test/feature_flags_SUITE_data/my_plugin:bazel_erlang_lib",
],
),
rabbitmq_integration_suite(
PACKAGE,
name = "feature_flags_with_unpriveleged_user_SUITE",
size = "large",
additional_beam = [
":feature_flags_SUITE_beam_files",
],
flaky = True,
shard_count = 2,
# The enabling_* tests chmod files and then expect writes to be blocked.
# This probably doesn't work because we are root in the remote docker image.
tags = ["exclusive"],
Expand Down
4 changes: 1 addition & 3 deletions deps/rabbit/test/feature_flags_SUITE.erl
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,12 @@ groups() ->
{enabling_on_single_node, [],
[
enable_feature_flag_in_a_healthy_situation,
enable_unsupported_feature_flag_in_a_healthy_situation,
enable_feature_flag_when_ff_file_is_unwritable
enable_unsupported_feature_flag_in_a_healthy_situation
]},
{enabling_in_cluster, [],
[
enable_feature_flag_in_a_healthy_situation,
enable_unsupported_feature_flag_in_a_healthy_situation,
enable_feature_flag_when_ff_file_is_unwritable,
enable_feature_flag_with_a_network_partition,
mark_feature_flag_as_enabled_with_a_network_partition
]},
Expand Down
74 changes: 74 additions & 0 deletions deps/rabbit/test/feature_flags_with_unpriveleged_user_SUITE.erl
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
%% This Source Code Form is subject to the terms of the Mozilla Public
%% License, v. 2.0. If a copy of the MPL was not distributed with this
%% file, You can obtain one at https://mozilla.org/MPL/2.0/.
%%
%% Copyright (c) 2018-2021 VMware, Inc. or its affiliates. All rights reserved.
%%

-module(feature_flags_with_unpriveleged_user_SUITE).

-include_lib("common_test/include/ct.hrl").
-include_lib("eunit/include/eunit.hrl").

-export([suite/0,
all/0,
groups/0,
init_per_suite/1,
end_per_suite/1,
init_per_group/2,
end_per_group/2,
init_per_testcase/2,
end_per_testcase/2,

enable_feature_flag_when_ff_file_is_unwritable/1
]).

suite() ->
[{timetrap, {minutes, 15}}].

all() ->
[
{group, enabling_on_single_node},
{group, enabling_in_cluster}
].

groups() ->
[
{enabling_on_single_node, [],
[
enable_feature_flag_when_ff_file_is_unwritable
]},
{enabling_in_cluster, [],
[
enable_feature_flag_when_ff_file_is_unwritable
]}
].

%% This suite exists to allow running a portion of the feature_flags_SUITE
%% under separate conditions in ci

init_per_suite(Config) ->
feature_flags_SUITE:init_per_suite(Config).

end_per_suite(Config) ->
feature_flags_SUITE:end_per_suite(Config).


init_per_group(Group, Config) ->
feature_flags_SUITE:init_per_group(Group, Config).

end_per_group(Group, Config) ->
feature_flags_SUITE:end_per_group(Group, Config).

init_per_testcase(Testcase, Config) ->
feature_flags_SUITE:init_per_testcase(Testcase, Config).

end_per_testcase(Testcase, Config) ->
feature_flags_SUITE:end_per_testcase(Testcase, Config).

%% -------------------------------------------------------------------
%% Testcases.
%% -------------------------------------------------------------------

enable_feature_flag_when_ff_file_is_unwritable(Config) ->
feature_flags_SUITE:enable_feature_flag_when_ff_file_is_unwritable(Config).