Increase classic queue shutdown timeout (backport #3409) #3473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
added 3 commits
September 21, 2021 13:47
A value that is too low will prevent the index from shutting down in time when there are many queues. This leads to the process being killed and on the next RabbitMQ restart a (potentially very long) dirty recovery is needed. The value of 10 minutes was chosen to mirror the shutdown timeout of the message store. Since both queues and message store need to have shut down gracefully in order to have a clean restart it makes sense to use the same value. Related: c40c262 (cherry picked from commit 09c8cd4)
(cherry picked from commit 180ce56) # Conflicts: # release-notes/3.8.23.md
Without this change the test could take a very long time to cleanup the queues and finish because of a race condition between the queue deletion and the federation link being restarted and declaring the queue again. (The test bidirectional was renamed to message_flow to better represent what it is doing.) (cherry picked from commit dfe0f4b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3409 done by Mergify.
Cherry-pick of 180ce56 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/