Skip to content

Disable the stream_plugin if stream feature flag is not enabled #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 14, 2021

Conversation

Gsantomaggio
Copy link
Member

Disable the stream_plugin if the feature flag is not enabled.
fixes #3557

Proposed Changes

fixes #3557

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

michaelklishin added a commit that referenced this pull request Oct 12, 2021
michaelklishin added a commit that referenced this pull request Oct 12, 2021
@Gsantomaggio
Copy link
Member Author

How to test the issue:

 gmake virgin-test-tmpdir
RABBITMQ_FEATURE_FLAGS="implicit_default_bindings"  gmake run-broker  PLUGINS="rabbitmq_stream rabbitmq_stream_management" 
  • Then try to access the management UI, the stream page should be not visible.
  • Try to access using a stream client the 5552 port should be closed.

inside the logs you should see:

 Unable to start the stream plugin. The stream_queue feature flag is disabled. You need to enable it then disable and re-enable the rabbitmq_stream plugin.  See https://www.rabbitmq.com/feature-flags.html

same for the UI:

Unable to show the stream management plugin. The stream_queue feature flag is disabled.

following the instructions by enabling the feature flags:

sbin/rabbitmqctl enable_feature_flag all 

then:

sbin/rabbitmq-plugins disable rabbitmq_stream
sbin/rabbitmq-plugins enable rabbitmq_stream_management 

at this point, everything should work as expected.

@Gsantomaggio Gsantomaggio changed the title [DON'T MERGE] Disable the stream_plugin if the feature flag Disable the stream_plugin if stream feature flag is not enabled Oct 13, 2021
@michaelklishin michaelklishin merged commit 2140562 into master Oct 14, 2021
@michaelklishin michaelklishin deleted the disable_stream_plugin_3557 branch October 14, 2021 15:45
michaelklishin added a commit that referenced this pull request Oct 14, 2021
Disable the stream_plugin if stream feature flag is not enabled  (backport #3562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream queues shouldn't be exposed if the feature flag is disabled
2 participants