Skip to content

Allow having multiple make run-broker simulatneously #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

binarin
Copy link
Contributor

@binarin binarin commented Oct 13, 2021

Proposed Changes

This makes running several make run-broker's in parallel (e.g. from different directories) easier, by providing config for all plugins that listen on tcp ports.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

It was automatically happening for e.g. `make start-cluster`.

But some plugins were not covered by default generated config, and
running rabbit from 2 different worktrees was a bit complicated.
@mergify mergify bot added the make label Oct 13, 2021
@michaelklishin
Copy link
Collaborator

This seems to work as expected as long as node name and RABBITMQ_NODE_PORT:

gmake run-broker PLUGINS="rabbitmq_management"
gmake run-broker PLUGINS="rabbitmq_management" RABBITMQ_NODE_PORT=5673 RABBITMQ_NODENAME=hare

@michaelklishin michaelklishin merged commit 84b0ade into master Oct 13, 2021
@michaelklishin michaelklishin deleted the run-broker-more-plugin-ports branch October 13, 2021 10:40
michaelklishin added a commit that referenced this pull request Oct 13, 2021
Allow having multiple `make run-broker` simulatneously (backport #3566)
michaelklishin added a commit that referenced this pull request Oct 13, 2021
Allow having multiple `make run-broker` simulatneously

(cherry picked from commit 84b0ade)

Conflicts:
	deps/rabbit_common/mk/rabbitmq-run.mk
@michaelklishin
Copy link
Collaborator

Backported to v3.8.x manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants