Skip to content

Fix memory_breakdown for connection procs #3570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

lhoguin
Copy link
Contributor

@lhoguin lhoguin commented Oct 13, 2021

Instead of trying to read the ranch_server ETS table directly,
use an internal Ranch function that does the same. While neither
are documented, the latter is less likely to change.

Proposed Changes

Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

A pull request that doesn't explain why the change was made has a much lower chance of being accepted.

If English isn't your first language, don't worry about it and try to communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Instead of trying to read the ranch_server ETS table directly,
use an internal Ranch function that does the same. While neither
are documented, the latter is less likely to change.
@lhoguin lhoguin force-pushed the lh-fix-memory_breakdown branch from 450a2f3 to 0ee8a06 Compare October 13, 2021 13:20
@lhoguin
Copy link
Contributor Author

lhoguin commented Oct 13, 2021

Recent push is a rebase to fix conflicts in release notes.

@michaelklishin
Copy link
Collaborator

I could reproduce the issue and verified that the fix works as expected. Note that we will have to backport this to v3.8.x manually because v3.8.x does not have 3.9 release notes.

@lhoguin
Copy link
Contributor Author

lhoguin commented Oct 13, 2021

Oh alright. :-)

@michaelklishin michaelklishin deleted the lh-fix-memory_breakdown branch October 13, 2021 14:58
michaelklishin added a commit that referenced this pull request Oct 13, 2021
Fix memory_breakdown for connection procs (backport #3570)
michaelklishin added a commit that referenced this pull request Oct 13, 2021
Fix memory_breakdown for connection procs

(cherry picked from commit 15116a6)

Conflicts:
	release-notes/3.9.8.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants