Skip to content

Update amqp10_client and amqp10_common for hex.pm publish #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2022
Merged

Update amqp10_client and amqp10_common for hex.pm publish #4245

merged 2 commits into from
Mar 30, 2022

Conversation

lukebakken
Copy link
Collaborator

Fixes #2577

Related rabbitmq/rabbitmq-ci#50

@lukebakken lukebakken requested review from dumbbell and HoloRin March 9, 2022 18:41
@lukebakken lukebakken self-assigned this Mar 9, 2022
@mergify mergify bot added the make label Mar 9, 2022
@mergify
Copy link

mergify bot commented Mar 11, 2022

This pull request modifies the erlang.mk build only. Should the makefiles be updated as well @lukebakken?

@lukebakken lukebakken force-pushed the rabbitmq-server-2577 branch from bb7fd4d to 6e94818 Compare March 14, 2022 22:19
@lukebakken lukebakken force-pushed the rabbitmq-server-2577 branch from 6e94818 to ea47a68 Compare March 28, 2022 21:59
@lukebakken lukebakken marked this pull request as ready for review March 28, 2022 22:09
dumbbell
dumbbell reviewed Mar 29, 2022
View reviewed changes
@lukebakken lukebakken force-pushed the rabbitmq-server-2577 branch from f8923bd to 38b953f Compare March 29, 2022 15:17
@lukebakken
Update amqp10_client and amqp10_common for hex.pm publish
d3e15b3 
Fixes #2577

Related rabbitmq/rabbitmq-ci#50

Yolo-copy amqp_client targets for dist

Update license short name

Remove unnecessary targets now that hex.pm exists
@lukebakken lukebakken force-pushed the rabbitmq-server-2577 branch from 38b953f to d3e15b3 Compare March 29, 2022 16:54
@lukebakken
Copy link
Collaborator Author

lukebakken commented Mar 29, 2022 •
edited
Loading

@pjk25 @dumbbell OK I think this is ready for a final review. Here's how I tested these changes:

  • Published to hex.pm:

    cd deps/amqp10_common
make RABBITMQ_VERSION=3.10.0-rc.1
make RABBITMQ_VERSION=3.10.0-rc.1 hex-publish

cd ../amqp10_client
make RABBITMQ_VERSION=3.10.0-rc.1
make RABBITMQ_VERSION=3.10.0-rc.1 hex-publish

    Produces:
    https://hex.pm/packages/amqp10_client
    https://hex.pm/packages/amqp10_common

  • Created test app - https://github.com/lukebakken/amqp10_test

  • Cloning and compiling test app works:

    lbakken@shostakovich ~/development/lukebakken/amqp10_test (main=)
$ rebar3 compile
===> Verifying dependencies...
===> Fetching amqp10_client v3.10.0-rc.1
===> Fetching amqp10_common v3.10.0-rc.1
===> Analyzing applications...
===> Compiling amqp10_common
===> Compiling amqp10_client
===> Analyzing applications...
===> Compiling amqp10_test

Don't forget this PR as well!
https://github.com/rabbitmq/rabbitmq-ci/pull/50

@lukebakken lukebakken mentioned this pull request Mar 29, 2022
Closed
HoloRin
HoloRin approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@HoloRin HoloRin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and at least one user has tested the package according to #2577

@HoloRin HoloRin merged commit 3c55369 into master Mar 30, 2022
@HoloRin HoloRin deleted the rabbitmq-server-2577 branch March 30, 2022 07:13
@mergify mergify bot mentioned this pull request Mar 30, 2022
Merged
michaelklishin added a commit that referenced this pull request Mar 30, 2022
@michaelklishin
Merge pull request #4375 from rabbitmq/mergify/bp/v3.10.x/pr-4245
454ee31 
Update amqp10_client and amqp10_common for hex.pm publish (backport #4245)
michaelklishin added a commit that referenced this pull request Mar 30, 2022
@michaelklishin
Merge pull request #4378 from rabbitmq/mergify/bp/v3.9.x/pr-4375
eb57e1b 
Update amqp10_client and amqp10_common for hex.pm publish (backport #4245) (backport #4375)
michaelklishin added a commit that referenced this pull request Mar 31, 2022
@michaelklishin
Merge pull request #4379 from rabbitmq/mergify/bp/v3.8.x/pr-4378
fd4db24 
Update amqp10_client and amqp10_common for hex.pm publish (backport #4245) (backport #4375) (backport #4378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumbbell dumbbell dumbbell left review comments

@HoloRin HoloRin HoloRin approved these changes

Assignees

@lukebakken lukebakken

Labels
make
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rabbitmq-amqp1.0-common: publish to hex.pm
3 participants
@lukebakken @dumbbell @HoloRin