Skip to content

Add consumer count to stream queue metrics (backport #4727) #4731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2022
Merged

Add consumer count to stream queue metrics (backport #4727) #4731

merged 3 commits into from
May 5, 2022

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 5, 2022

This is an automatic backport of pull request #4727 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@acogoluegnes @mergify
Add consumer count to stream queue metrics
7b50e1e 
This commit adds the "consumers" metrics to stream queues (consumer count).
It is computed by counting the element of the consumer_created ETS table
for the given stream queue and for each member of the Osiris cluster.

Fixes #4622

(cherry picked from commit f3dfb50)
@acogoluegnes @mergify
Use rabbit_misc:rpc_call/5 for RPC
97bc53e 
It handles common RPC errors.

References #4622

(cherry picked from commit d5635a4)
@acogoluegnes @mergify
Skip test in mixed-version cluster mode
548db5b 
Otherwise needs to enable stream feature flag.

References #4622

(cherry picked from commit febefbd)
@michaelklishin michaelklishin merged commit c88219a into v3.10.x May 5, 2022
@michaelklishin michaelklishin deleted the mergify/bp/v3.10.x/pr-4727 branch May 5, 2022 11:52
@mergify mergify bot mentioned this pull request May 5, 2022
Merged
acogoluegnes added a commit that referenced this pull request May 5, 2022
@acogoluegnes
Merge pull request #4732 from rabbitmq/mergify/bp/v3.9.x/pr-4731
59b5ccc 
Add consumer count to stream queue metrics (backport #4727) (backport #4731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@acogoluegnes acogoluegnes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelklishin @acogoluegnes