Skip to content

Set deleting exchange status #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 11, 2016
Merged

Set deleting exchange status #533

merged 6 commits into from
Jan 11, 2016

Conversation

dcorbacho
Copy link
Contributor

  • Avoids race condition between declare and delete

Solves rabbitmq/rabbitmq-federation#7

* Avoids race condition between declare and delete
@michaelklishin
Copy link
Collaborator

Oops, my comments ended up being on a commit in a fork.

I suggest that we rename exchange-delete to exchange-delete-in-progress. This is a fairly unexpected use of runtime parameters but no different in practice over using a separate local table, so why not.

Also, have we considered what happens when a node fails right after storing the parameter, then coming up? Runtime parameters are stored in a durable table. Should we perhaps clean up all such parameters on boot?

@dcorbacho
Copy link
Contributor Author

Just renamed the parameter.

Good point in the persistence, you're right, I will look at it. Maybe the runtime-parameters are not such a good idea? I used that because was the most similar structure already in place.

@michaelklishin
Copy link
Collaborator

It is indeed a similar structure and it is already scoped per vhost, just like what we want. So I'm OK with using it.

@michaelklishin
Copy link
Collaborator

There are test failures in the Java client (exchange.delete, exchange.declare tests). I'm investigating.

This makes sure that values that were set right before
node failure or restart are not retained.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants