Skip to content

See #7389. One tick process per quorum queue #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

See #7389. One tick process per quorum queue #7668

merged 1 commit into from
Mar 30, 2023

Conversation

SimonUnge
Copy link
Collaborator

Proposed Changes

Using the pid and aux state trick to check if the QQ already have a process running for a tick.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue Only allow one transient "tick" process per quorum queue #7389)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

kjnilsson
kjnilsson reviewed Mar 20, 2023
View reviewed changes
kjnilsson
kjnilsson requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@kjnilsson kjnilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but added a suggestion to avoid issuing a monitor effect for the tick process.

@SimonUnge
Copy link
Collaborator Author

This looks good but added a suggestion to avoid issuing a monitor effect for the tick process.

Fixed!

kjnilsson
kjnilsson requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@kjnilsson kjnilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nearly there! :)

@SimonUnge
Copy link
Collaborator Author

Done, part 2

@SimonUnge SimonUnge requested a review from kjnilsson March 20, 2023 22:07
kjnilsson
kjnilsson previously approved these changes Mar 21, 2023
View reviewed changes
@kjnilsson
Copy link
Contributor

@SimonUnge approved, please can you squash all your commits into one?

@SimonUnge SimonUnge force-pushed the ra_tick_only_one_pid branch from 1f84a14 to f802d6b Compare March 21, 2023 16:11
@SimonUnge
Copy link
Collaborator Author

@SimonUnge approved, please can you squash all your commits into one?

Done!

@SimonUnge
Copy link
Collaborator Author

@michaelklishin Should I rebase this on main?

@michaelklishin michaelklishin merged commit 9363648 into rabbitmq:main Mar 30, 2023
@michaelklishin
Copy link
Collaborator

@michaelklishin Should I rebase this on main?

I used Rebase and merge on GH. Thank you for your ongoing contributions!

@mergify mergify bot mentioned this pull request Mar 30, 2023
Merged
@kjnilsson
Copy link
Contributor

@mergify backport v3.11.x

@mergify
Copy link

mergify bot commented May 23, 2023 •
edited
Loading

backport v3.11.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request May 23, 2023
Merged
@rabbitmq rabbitmq deleted a comment from mergify bot May 23, 2023
michaelklishin added a commit that referenced this pull request May 23, 2023
@michaelklishin
Merge pull request #8284 from rabbitmq/mergify/bp/v3.11.x/pr-7668
6b2d26d 
See #7389. One tick process per quorum queue (backport #7668)
michaelklishin added a commit that referenced this pull request May 29, 2023
@michaelklishin
Credit Simon in #7668
f829d48 
(cherry picked from commit 807441ebea1c1d895600b13fed5e20e031047978)
michaelklishin added a commit that referenced this pull request May 29, 2023
@michaelklishin
Credit Simon in #7668
669228e 
(cherry picked from commit 807441ebea1c1d895600b13fed5e20e031047978)
michaelklishin added a commit that referenced this pull request May 29, 2023
@michaelklishin
Credit Simon in #7668
bca5100 
(cherry picked from commit 807441ebea1c1d895600b13fed5e20e031047978)
(cherry picked from commit f829d48)
@michaelklishin michaelklishin mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjnilsson kjnilsson kjnilsson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonUnge @kjnilsson @michaelklishin