Classic queues: make CQv2 the new default #7672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CQv2 is significantly more efficient (x2-4 on some workloads), has lower and more predictable memory footprint, and eliminates the need to make classic queues lazy to achieve that predictability. Per several discussions with the team.
michaelklishin
changed the title
|
We have decided to leave this for 3.13.0. |
|
I confirm what @ansd says in #7677 linked above, this PR breaks CI. The This is reported by the checks in this pull request and all other pull requests rebased on Reverting this patch fixes the regression. |
Merged
HoloRin
added a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CQv2 is significantly more efficient (x2-4 on some workloads), has lower and more predictable memory footprint, and eliminates the need to make classic queues lazy to achieve that predictability.
Per several discussions with the team.