-
Notifications
You must be signed in to change notification settings - Fork 3.9k
See #7593. Use connection_max to stop connections in rabbitmq #7753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michaelklishin
merged 1 commit into
rabbitmq:main
from
SimonUnge:sunge/max_node_connection
Mar 29, 2023
Merged
See #7593. Use connection_max to stop connections in rabbitmq #7753
michaelklishin
merged 1 commit into
rabbitmq:main
from
SimonUnge:sunge/max_node_connection
Mar 29, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind the previous comment I understand now. Looks good to me, thanks!
michaelklishin
approved these changes
Mar 29, 2023
We don't have a lot of details but in #7787 this new function runs into an exception when a client connects. |
Here are various config files |
RABBITMQ_NODENAME=rabbit@primary
RABBITMQ_LOG_BASE=/var/log/kolla/rabbitmq
RABBITMQ_DIST_PORT=25672
RABBITMQ_PID_FILE=/var/lib/rabbitmq/mnesia/rabbitmq.pid
RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS="-kernel inetrc '/etc/rabbitmq/erl_inetrc' +S 2:2 +sbwt none +sbwtdcpu none +sbwtdio none"
RABBITMQ_CTL_ERL_ARGS=""
export ERL_EPMD_ADDRESS=192.0.2.1
export ERL_EPMD_PORT=4369
export ERL_INETRC=/etc/rabbitmq/erl_inetrc [
{kernel, [
{inet_dist_use_interface, {192,0,2,1}},
{inet_dist_listen_min, 25672},
{inet_dist_listen_max, 25672}
]}
]. |
A follow-up that will go into |
michaelklishin
added a commit
that referenced
this pull request
Mar 31, 2023
michaelklishin
added a commit
that referenced
this pull request
Mar 31, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Closes #7593
Use connection_max to limit connections per node, from rabbitmq code, instead of ranch.
Add ranch_connection_max setting for setting ranch connection max.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
N/A