Remove unused rabbit_http_util functions #8303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The associated eunit tests were failing on Windows and OTP 26. Since they are unused, there is no reason to keep them around. https://app.buildbuddy.io/invocation/2d08b45f-41e1-464b-8e82-11da0334207b?target=%2F%2Fdeps%2Frabbit_common%3Aeunit#@17
mkuratczyk
approved these changes
May 23, 2023
There was a problem hiding this comment.
OTP26 tests no longer fail - thanks!
https://github.com/rabbitmq/rabbitmq-server/actions/runs/5060664095/jobs/9083835965
(note: they seem to still hang towards the end but that's unrelated)
mkuratczyk
deleted the
lukebakken/remove-unused-rabbit_http_util-functions
branch
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2023
The associated eunit tests were failing on Windows and OTP 26. Since they are unused, there is no reason to keep them around. https://app.buildbuddy.io/invocation/2d08b45f-41e1-464b-8e82-11da0334207b?target=%2F%2Fdeps%2Frabbit_common%3Aeunit#@17 (cherry picked from commit 9e170e9)
mkuratczyk
pushed a commit
that referenced
this pull request
May 24, 2023
The associated eunit tests were failing on Windows and OTP 26. Since they are unused, there is no reason to keep them around. https://app.buildbuddy.io/invocation/2d08b45f-41e1-464b-8e82-11da0334207b?target=%2F%2Fdeps%2Frabbit_common%3Aeunit#@17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The associated eunit tests were failing on Windows and OTP 26. Since they are unused, there is no reason to keep them around.
https://app.buildbuddy.io/invocation/2d08b45f-41e1-464b-8e82-11da0334207b?target=%2F%2Fdeps%2Frabbit_common%3Aeunit#@17