Skip to content

Add looking_glass #8344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2023
Merged

Add looking_glass #8344

merged 2 commits into from
May 30, 2023

Conversation

HoloRin
Copy link
Contributor

@HoloRin HoloRin commented May 25, 2023

Adds looking_glass to the deps/rabbit plt file so that unknowns no longer need be ignored

@mergify mergify bot added the bazel label May 25, 2023
@HoloRin
Copy link
Contributor Author

HoloRin commented May 26, 2023

I would like to wait until looking_glass has been published to BCR before this is merged. Currently this PR uses an override, which when removed I will take this out of draft status.

@michaelklishin michaelklishin changed the title Add looking_glass DO NOT MERGE Add looking_glass May 26, 2023
@HoloRin HoloRin force-pushed the rin/add-looking_glass branch from 92ee470 to 218db9e Compare May 30, 2023 08:11
@HoloRin HoloRin changed the title DO NOT MERGE Add looking_glass Add looking_glass May 30, 2023
@HoloRin HoloRin marked this pull request as ready for review May 30, 2023 08:39
@HoloRin
Copy link
Contributor Author

HoloRin commented May 30, 2023

looking_glass has now been published in BCR

@HoloRin HoloRin merged commit f8b3409 into main May 30, 2023
@HoloRin HoloRin deleted the rin/add-looking_glass branch May 30, 2023 14:15
michaelklishin added a commit that referenced this pull request May 30, 2023
michaelklishin added a commit that referenced this pull request May 30, 2023
michaelklishin added a commit that referenced this pull request May 30, 2023
Add looking_glass (backport #8344) (backport #8413) (backport #8416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant