Skip to content

Remove '\n' from Access refused stomp log. #8462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Jun 3, 2023

Proposed Changes

Yeah, just remove it and close #2568.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

Tested with

python -m stomp -H localhost -P 61613 -U qwe

@ikavgo ikavgo changed the title Remove '\n' from Access refused stomp log. close #2568 Remove '\n' from Access refused stomp log. Jun 3, 2023
@michaelklishin michaelklishin modified the milestone: 3.12.1 Jun 3, 2023
@ikavgo ikavgo force-pushed the ik-stomp-access-log-fix-2568 branch from 1befbf4 to 4404f3c Compare June 4, 2023 19:58
@michaelklishin michaelklishin merged commit c241b09 into main Jun 5, 2023
@michaelklishin michaelklishin deleted the ik-stomp-access-log-fix-2568 branch June 5, 2023 02:40
michaelklishin added a commit that referenced this pull request Jun 5, 2023
Remove '\n' from Access refused stomp log.  (backport #8462)
michaelklishin added a commit that referenced this pull request Jun 5, 2023
Remove '\n' from Access refused stomp log.  (backport #8462) (backport #8464)
@michaelklishin michaelklishin added this to the 3.12.1 milestone Jun 5, 2023
michaelklishin added a commit that referenced this pull request Jun 5, 2023
Remove '\n' from Access refused stomp log.  (backport #8462) (backport #8464) (backport #8465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "\n" from the "Access refused for user 'xxxxxx'\n" log string
3 participants