Infinity loop in synchronisation of priority queues #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 21, 2016 08:23
Neither amqqueue_process, master or slave modules are aware of the priority data expected by this function, it must be stored and retrieved internal.
It is up to the individual implementation to decide what to erase, i.e. priority queues have one index per priority
|
I'm getting test failures, shared details on Slack. |
dcorbacho
pushed a commit
that referenced
this pull request
Nov 18, 2020
This value is used at listener registration and will show up in `rabbitmq-diagnostics listeners' output. Closes #857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves two of the bugs in #802, the third one can only be fixed in
masteras detecting a stale slave requires changes on a mnesia table.The unit tests try to trigger the bugs in a multinode test. The
invokecrash seems to be triggered consistently, but it cannot be guaranteed on any environment. Thus, the suite also contains an individual test case to force it.