Skip to content

Compile on OTP 19.0 #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 28, 2016
Merged

Compile on OTP 19.0 #861

merged 3 commits into from
Jun 28, 2016

Conversation

michaelklishin
Copy link
Collaborator

Fixes #860.

There are two primary changes:

  • Type spec syntax (backwards compatible)
  • rand is used instead of random

Depends on rabbitmq/rabbitmq-common#111.

@michaelklishin michaelklishin added this to the n/a milestone Jun 26, 2016
@michaelklishin michaelklishin changed the title Compile on OTP 19.0 DO NOT MERGE Compile on OTP 19.0 Jun 26, 2016
@michaelklishin
Copy link
Collaborator Author

OK, apparently the rand module is only available in 18.0+, so this needs more work.

dumbbell added 2 commits June 28, 2016 16:02
@dumbbell
Use the new -spec format
fa20bbc 
The old format is removed in Erlang 19.0, leading to build errors.

Also, get rid of the `use_specs` macro and thus always define -spec() &
friends.

While here, unnify the style of -type and -spec.

References #860.
[#118562897]
[#122335241]
@dumbbell
Use the new rand_compat module to transition from random to rand
2735990 
References #860.
[#122335241]
@dumbbell dumbbell force-pushed the rabbitmq-server-860 branch from 693b465 to 2735990 Compare June 28, 2016 14:02
@michaelklishin michaelklishin changed the title DO NOT MERGE Compile on OTP 19.0 Compile on OTP 19.0 Jun 28, 2016
@michaelklishin michaelklishin merged commit 0923c96 into stable Jun 28, 2016
@michaelklishin
Copy link
Collaborator Author

@dumbbell thank you, this now needs merging into master.

@dumbbell dumbbell deleted the rabbitmq-server-860 branch June 29, 2016 07:12
@dumbbell
Copy link
Collaborator

This PR is merged to master.

dcorbacho added a commit that referenced this pull request Nov 18, 2020
@dcorbacho
Merge pull request #861 from rabbitmq/gen-server-call-on-closing-conn…
5f4fabf 
…ection-request

Add gen_server:call to PID on closing connection request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dumbbell dumbbell

Labels
None yet
Projects
None yet
Milestone
n/a
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelklishin @dumbbell