Skip to content

Table column selection pane cutts off "Close", and other attributes #8701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2023

Conversation

Antsthebul
Copy link
Contributor

@Antsthebul Antsthebul commented Jun 29, 2023

Proposed Changes

Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

As metnioned here #8660 , "close" and other selectable attributes are hidden/cut off. Hoping this is an "obvious fix".
Adjsuted CSS to allow scrolling and reduced the height of the popup window

Results

image

A pull request that doesn't explain why the change was made has a much lower chance of being accepted.

If English isn't your first language, don't worry about it and try to communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

Closes #8660

@pivotal-cla
Copy link

@Antsthebul Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@Antsthebul Antsthebul marked this pull request as draft June 29, 2023 19:02
@michaelklishin
Copy link
Collaborator

@pivotal-cla this is an obvious fix

@pivotal-cla
Copy link

@Antsthebul This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@michaelklishin
Copy link
Collaborator

@Antsthebul thank you. Should this still be a draft?

@Antsthebul
Copy link
Contributor Author

Antsthebul commented Jun 30, 2023

@Antsthebul thank you. Should this still be a draft?

No problem!
I notced the fix I created for maybe the pane, look ugly in other screens, Ill take another look later today and push up a fix

@Antsthebul Antsthebul marked this pull request as ready for review June 30, 2023 17:41
@michaelklishin michaelklishin added this to the 3.12.2 milestone Jul 2, 2023
@michaelklishin
Copy link
Collaborator

michaelklishin commented Jul 2, 2023

I tried several desktop browsers and iPhone 8, iPhone 8 Plus in Safari's Responsive Design mode, and these changes address #8660 in all of them.

Thank you, @Antsthebul!

@michaelklishin michaelklishin merged commit 84ea5d3 into rabbitmq:main Jul 2, 2023
michaelklishin added a commit that referenced this pull request Jul 2, 2023
Table column selection pane cutts off "Close", and other attributes (backport #8701)
michaelklishin added a commit that referenced this pull request Jul 3, 2023
Table column selection pane cutts off "Close", and other attributes (backport #8701) (backport #8731)
michaelklishin added a commit that referenced this pull request Jul 3, 2023
Table column selection pane cutts off "Close", and other attributes (backport #8701) (backport #8731) (backport #8732)
@michaelklishin michaelklishin removed this from the 3.12.2 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table column selection pane cannot be closed on screens with very limited vertical space
3 participants