-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Table column selection pane cutts off "Close", and other attributes #8701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Antsthebul Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@pivotal-cla this is an obvious fix |
@Antsthebul This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
@Antsthebul thank you. Should this still be a draft? |
No problem! |
I tried several desktop browsers and iPhone 8, iPhone 8 Plus in Safari's Responsive Design mode, and these changes address #8660 in all of them. Thank you, @Antsthebul! |
Table column selection pane cutts off "Close", and other attributes (backport #8701)
Proposed Changes
Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
As metnioned here #8660 , "close" and other selectable attributes are hidden/cut off. Hoping this is an "obvious fix".
Adjsuted CSS to allow scrolling and reduced the height of the popup window
Results
A pull request that doesn't explain why the change was made has a much lower chance of being accepted.
If English isn't your first language, don't worry about it and try to communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
Closes #8660