rabbit_feature_flags: Reset the registry before the boot-time init #8749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] After a `stop_app` + `start_app`, the feature flags registry is left loaded. If the deprecated features are reconfigured in the configuration file in between, their new state won't be taken into account if the registry initialization is skipped because it is already loaded. Therefore, we need to reset the registry before we proceed with the first initialization. That's ok because feature flags states were saved to disc already. It will be restored correctly like if the Erlang node was fully stopped and restarted. [How] We unload the `rabbit_ff_registry` module just before we initialize it again in `rabbit_prelaunch_feature_flags`.
…features` conf [Why] This makes it clear when default states are being used because there is no configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
After a
stop_app+start_app, the feature flags registry is left loaded. If the deprecated features are reconfigured in the configuration file in between, their new state won't be taken into account if the registry initialization is skipped because it is already loaded.Therefore, we need to reset the registry before we proceed with the first initialization. That's ok because feature flags states were saved to disc already. It will be restored correctly like if the Erlang node was fully stopped and restarted.
How
We unload the
rabbit_ff_registrymodule just before we initialize it again inrabbit_prelaunch_feature_flags.