STOMP: introduce a max frame size limit

[ikavgo]

Proposed Changes

Add frame size limit.

The default is 4 MiB.

Cloeses #2567.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)
• Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• I have added tests that prove my fix is effective or that my feature works
• All tests pass locally with my changes
• If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
• If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

I would like to have it inside parser, it's way more intrusive in parser. It's a work in progress, but this size limit needed urgently so here it is. I will migrate it to parser via bigger PR.

[ikavgo]

@michaelklishin @mkuratczyk I'm open to changing the default limit. Also current implementation is coarse with tolerance up to buffer size (well it read from network already anyway). If end of the frame is inside of newly read buffer and it exceeds the limit parser is allowed to continue and return frame. in the next round I will move this check inside parser itself.

[michaelklishin]

Let's start with a 1 MiB limit and ship this in 3.13.0.

[ikavgo]

why no backport to 3.12?

[michaelklishin]

Because previously there was no limit and now there is, and any system where STOMP frame size exceeds it will run into rejected publishes.

[ikavgo]

I see it more like a critical bug fix. But I'll gladly accept your POV.

[michaelklishin]

Maybe a higher limit such as 4 MiB would be acceptable. I'm OK with using that and backporting. Let me bump the limit one more time.

[michaelklishin]

The OCI build failures seem unrelated.