Skip to content

Remove flaky label from queue test suites #8825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

dcorbacho
Copy link
Contributor

Tests that are flake by default do not increase confidence on any code base. Just test cases that have external dependencies should be marked as such.

Some work has been done to make these test suites more resilient, but not all time-dependent issues are detected on our dev boxes. It is essential to obtain CI reports of such failures, so we can make the tests more robust and fix any hidden bug.

Tests that are flake by default do not increase confidence on any
code base. Just test cases that have external dependencies should
be marked as such.

Some work has been done to make these test suites more resilient,
but not all time-dependent issues are detected on our dev boxes.
It is essential to obtain CI reports of such failures, so we can
make the tests more robust and fix any hidden bug.
@dcorbacho dcorbacho requested a review from michaelklishin July 10, 2023 14:26
@mergify mergify bot added the bazel label Jul 10, 2023
@michaelklishin michaelklishin merged commit 3184821 into main Jul 10, 2023
@michaelklishin michaelklishin deleted the remove-flaky-labels branch July 10, 2023 15:37
michaelklishin added a commit that referenced this pull request Jul 10, 2023
Remove flaky label from queue test suites (backport #8825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants