Osiris 1.6.7 #9418
Merged
Osiris 1.6.7 #9418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
osiris-1.6.6
branch
from
6f36b1b to
f527e92
Compare
This version contains a bit more error handling during replica start to avoid logging process crashes during RabbitMQ shutdown. rabbit_stream_queue: avoid double local pid query When starting a new consumer. Also move some metrics registration a bit later when we know we are likely to succeed.
kjnilsson
force-pushed
the
osiris-1.6.6
branch
from
f527e92 to
19ab882
Compare
michaelklishin
added a commit
that referenced
this pull request
Sep 15, 2023
michaelklishin
added a commit
that referenced
this pull request
Sep 15, 2023
Osiris 1.6.7 (backport #9418)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version contains a bit more error handling during replica start to avoid logging process crashes during RabbitMQ shutdown. It also handles all replica reader exits by terminating with
{shutdown, Info}rather than crashing.There is also an optimisation to avoid a double call to
rabbit_stream:coordinator:local_pid/1when creating a new consumer.