Do not log HTTP[S] listener options #9573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
changed the title
These messages are now of little use. References [1]. 1. #9569
michaelklishin
force-pushed
the
mk-do-no-log-listener-options
branch
from
5e74f77 to
04ecfc9
Compare
michaelklishin
added a commit
that referenced
this pull request
Sep 28, 2023
Do not log HTTP[S] listener options (backport #9573)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are of little use and even though they were logged at
debuglevel and only on node boot (that is, you have to explicitly opt-in to use debug logging viarabbitmq.conf),technically this could lead to the logging of a private key password.
So we might as well not log them at all.