Skip to content

Khepri migration: match expected records #9802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

dcorbacho
Copy link
Contributor

@dcorbacho dcorbacho commented Oct 26, 2023

During metadata store migration, Mnesia might generate messages for Table-Key pairs for in-flight writes.
These are skipped by mnesia-khepri-migration, as do not contain enough info to copy the record, but we ensure here that none comes through and we try to process it.

The event with Table-Record is generated at the time of write, which is properly processed after the initial copy of data.

Requires khepri_mnesia_migration 0.2.1

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

@dcorbacho dcorbacho changed the title Khepri: handle pairs Table-Key received during metadata store migration WIP Khepri: handle pairs Table-Key received during metadata store migration Oct 26, 2023
@dcorbacho dcorbacho force-pushed the migration-live-insertions branch from d3f9284 to 8c35c8e Compare October 27, 2023 05:42
@mergify mergify bot added the bazel label Oct 27, 2023
@dcorbacho dcorbacho force-pushed the migration-live-insertions branch from 8c35c8e to 82ea0d9 Compare October 27, 2023 09:18
@dcorbacho dcorbacho changed the title WIP Khepri: handle pairs Table-Key received during metadata store migration Khepri migration: match expected records Oct 27, 2023
During metadata store migration, Mnesia might generate messages
for Table-Key pairs for in-flight writes.
These are skipped by mnesia-khepri-migration, as do not contain
enough info to copy the record, but we ensure here that none
comes through and we try to process it.

The event with Table-Record is generated at the time of write,
which is properly processed after the initial copy of data.
@dcorbacho dcorbacho force-pushed the migration-live-insertions branch from 82ea0d9 to 2d4854c Compare October 30, 2023 08:10
@dcorbacho dcorbacho marked this pull request as ready for review October 30, 2023 10:02
@dcorbacho dcorbacho added this to the 3.13.0 milestone Oct 30, 2023
Copy link
Collaborator

@dumbbell dumbbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@dumbbell dumbbell merged commit d3c14a4 into main Oct 30, 2023
@dumbbell dumbbell deleted the migration-live-insertions branch October 30, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants