Skip to content

Remove erlang:port_command/2 hack #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Remove erlang:port_command/2 hack #9810

merged 1 commit into from
Oct 27, 2023

Conversation

ansd
Copy link
Member

@ansd ansd commented Oct 27, 2023

as selective receives are efficient in OTP 26:

OTP-18431
Application(s):
compiler, stdlib
Related Id(s):
PR-6739
Improved the selective receive optimization, which can now be enabled for references returned from other functions.
This greatly improves the performance of gen_server:send_request/3, gen_server:wait_response/2, and similar functions.

as selective receives are efficient in OTP 26:
```
OTP-18431
Application(s):
compiler, stdlib
Related Id(s):
PR-6739
Improved the selective receive optimization, which can now be enabled for references returned from other functions.
This greatly improves the performance of gen_server:send_request/3, gen_server:wait_response/2, and similar functions.
```
@ansd ansd mentioned this pull request Oct 27, 2023
@michaelklishin michaelklishin added this to the 3.13.0 milestone Oct 27, 2023
@ansd ansd marked this pull request as ready for review October 27, 2023 09:59
@michaelklishin michaelklishin merged commit bc16e9f into main Oct 27, 2023
@michaelklishin michaelklishin deleted the port_command branch October 27, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants