rabbit_khepri: Fix error handling with net_adm:ping/1
#9929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] The initial implementation was a bit too optimistic: it just asserted that `net_adm:ping/1` returned pong. This led to a crash if it was not the case. [How] It is better to handle an error from `net_adm:ping/1` and return something appropriate instead of crashing. The rest of the function already does that. It improves the integration with peer discovery.
dumbbell
force-pushed
the
fix-error-handling-in-rabbit_khepri-add_member
branch
from
c6ca320 to
4ebaf7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The initial implementation was a bit too optimistic: it just asserted that
net_adm:ping/1returned pong. This led to a crash if it was not the case.How
It is better to handle an error from
net_adm:ping/1and return something appropriate instead of crashing. The rest of the function already does that.It improves the integration with peer discovery.