Fix dyn shovel child_exists check for old id format #9968

gomoripeti · 2023-11-21T23:40:26Z

Proposed Changes

Because the clause ({{_, N}, _, _, _}) -> N =:= Name; matches both new and old id format but always returns false for old id format, child_exists also returned false for old ids.

Also rename SupId to ChildId to be pedantically correct.

Follow-up of #9965

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

Bug fix (non-breaking change which fixes issue #NNNN)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause an observable behavior change in existing systems)
Documentation improvements (corrections, new content, etc)
Cosmetic change (whitespace, formatting, etc)
Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING.md document
I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
I have added tests that prove my fix is effective or that my feature works
All tests pass locally with my changes
If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Because the clause `({{_, N}, _, _, _}) -> N =:= Name;` matches both new and old id format but always returns false for old id format, `child_exists` also returned false for old ids. Also rename SupId to ChildId to be pedantically correct.

gomoripeti · 2023-11-22T00:20:21Z

I did manual testing of this patch together with #9965.

Upgraded a 3-node cluster from 3.12.6 to 3.12.9. Reproduced issues and verified below worked after applying the patch

no duplicates appear after app restart
updating shovel arguments works
deleting shovel works
cleanup_specs does not do extra calls

Details

Create 3-node cluster with 3.12.6
- create queues q1..q6
- create shovel sh_old1 q1 -> q2
- create shovel sh_old2 q3 -> q4

$ rabbitmqctl list_parameters --vhost gzewjyxk
Listing runtime parameters for vhost "gzewjyxk" ...
component	name	value
shovel	sh_old2	{"ack-mode":"on-confirm","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q4","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q3","src-uri":"amqp:///gzewjyxk"}
shovel	sh_old1	{"ack-mode":"on-confirm","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q2","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q1","src-uri":"amqp:///gzewjyxk"}

$ rabbitmqctl eval '[element(1, C) || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{<<"gzewjyxk">>,<<"sh_old2">>},
 {<<"gzewjyxk">>,<<"sh_old1">>}]

Upgrade to 3.12.9
Duplicate workers appeared

$ rabbitmqctl eval '[element(1, C) || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{<<"gzewjyxk">>,<<"sh_old1">>},
 {<<"gzewjyxk">>,<<"sh_old2">>},
 {[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}},
 {[<<"gzewjyxk">>,<<"sh_old2">>],{<<"gzewjyxk">>,<<"sh_old2">>}}]

Create new shovel sh_new1 q5->q6

$ rabbitmqctl set_parameter --vhost gzewjyxk shovel sh_new1 '{"ack-mode":"on-confirm","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q6","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q5","src-uri":"amqp:///gzewjyxk"}'
Setting runtime parameter "sh_new1" for component "shovel" to "{"ack-mode":"on-confirm","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q6","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q5","src-uri":"amqp:///gzewjyxk"}" in vhost "gzewjyxk" ...

$ rabbitmqctl eval '[element(1, C) || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}},
 {<<"gzewjyxk">>,<<"sh_old1">>},
 {<<"gzewjyxk">>,<<"sh_old2">>},
 {[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}},
 {[<<"gzewjyxk">>,<<"sh_old2">>],{<<"gzewjyxk">>,<<"sh_old2">>}}]

Clean up duplicate worker for sh_old1 with new id

$ rabbitmqctl eval 'mirrored_supervisor:terminate_child(rabbit_shovel_dyn_worker_sup_sup, {[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}}).'
ok

$ rabbitmqctl eval 'mirrored_supervisor:delete_child(rabbit_shovel_dyn_worker_sup_sup, {[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}}).'
ok

$ rabbitmqctl eval '[element(1, C) || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}},
 {<<"gzewjyxk">>,<<"sh_old1">>},
 {<<"gzewjyxk">>,<<"sh_old2">>},
 {[<<"gzewjyxk">>,<<"sh_old2">>],{<<"gzewjyxk">>,<<"sh_old2">>}}]

Update sh_old1 by modifying ack-mode. Duplicate worker appears again. Old worker with old args not stopped

$ rabbitmqctl set_parameter --vhost gzewjyxk shovel       sh_old1 '{"ack-mode":"on-publish","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q1","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q2","src-uri":"amqp:///gzewjyxk"}'
Setting runtime parameter "sh_old1" for component "shovel" to "{"ack-mode":"on-publish","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q1","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q2","src-uri":"amqp:///gzewjyxk"}" in vhost "gzewjyxk" ...

$ rabbitmqctl eval '[element(1, C) || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}},
 {[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}},
 {<<"gzewjyxk">>,<<"sh_old1">>},
 {<<"gzewjyxk">>,<<"sh_old2">>},
 {[<<"gzewjyxk">>,<<"sh_old2">>],{<<"gzewjyxk">>,<<"sh_old2">>}}]

Tracing - stop_child not called

22:41:26.817764 <0.4649.0> rabbit_shovel_dyn_worker_sup_sup:child_exists({<<"gzewjyxk">>,<<"sh_old1">>})

22:41:26.823722 <0.4649.0> rabbit_shovel_dyn_worker_sup_sup:child_exists/1 --> false

Clean up duplicate worker of sh_old2 with new id

$ rabbitmqctl eval 'mirrored_supervisor:terminate_child(rabbit_shovel_dyn_worker_sup_sup, {[<<"gzewjyxk">>,<<"sh_old2">>],{<<"gzewjyxk">>,<<"sh_old2">>}}).'
ok

$ rabbitmqctl eval 'mirrored_supervisor:delete_child(rabbit_shovel_dyn_worker_sup_sup, {[<<"gzewjyxk">>,<<"sh_old2">>],{<<"gzewjyxk">>,<<"sh_old2">>}}).'
ok

$ rabbitmqctl eval '[element(1, C) || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}},
 {[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}},
 {<<"gzewjyxk">>,<<"sh_old1">>},
 {<<"gzewjyxk">>,<<"sh_old2">>}]

Delete shovel sh_old2 fails. Parameters removed but worker/status remains intact

$ rabbitmqctl clear_parameter --vhost gzewjyxk shovel sh_old2
Clearing runtime parameter "sh_old2" for component "shovel" on vhost "gzewjyxk" ...
Error:
{{:badmatch, {:error, :not_found}}, [{:rabbit_shovel_dyn_worker_sup_sup, :stop_child, 1, [file: ~c"rabbit_shovel_dyn_worker_sup_sup.erl", line: 73]}, {:rabbit_runtime_parameters, :clear, 4, []}]}

$ rabbitmqctl eval '[element(1, C) || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}},
 {[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}},
 {<<"gzewjyxk">>,<<"sh_old1">>},
 {<<"gzewjyxk">>,<<"sh_old2">>}]

$ rabbitmqctl list_parameters --vhost gzewjyxk
Listing runtime parameters for vhost "gzewjyxk" ...
component	name	value
shovel	sh_old1	{"ack-mode":"on-publish","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q1","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q2","src-uri":"amqp:///gzewjyxk"}
shovel	sh_new1	{"ack-mode":"on-confirm","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q6","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q5","src-uri":"amqp:///gzewjyxk"}

$ rabbitmqctl shovel_status
Shovel status on node rabbit@node-01
destination	destination_protocol	destination_queue	last_changed	name	source	source_protocol	source_queue	state	termination_reason	type	vhost
amqp:///gzewjyxk	amqp091	q1	2023-11-21 22:41:26	sh_old1	amqp:///gzewjyxk	amqp091	q2	running		dynamic	gzewjyxk
amqp:///gzewjyxk	amqp091	q6	2023-11-21 22:34:56	sh_new1	amqp:///gzewjyxk	amqp091	q5	running		dynamic	gzewjyxk
amqp:///gzewjyxk	amqp091	q4	2023-11-21 22:10:33	sh_old2	amqp:///gzewjyxk	amqp091	q3	running		dynamic	gzewjyxk

Trace cleanup_specs calling delete_child - called multiple times

(rabbit@node-01)1> recon_trace:calls([{rabbit_shovel_dyn_worker_sup_sup, cleanup_spec, return_trace}, {mirrored_supervisor, delete_child, fun(_) -> exception_trace() end}], 20).
1
(rabbit@node-01)2> rabbit_shovel_dyn_worker_sup_sup:cleanup_specs().

22:48:18.764390 <0.5627.0> mirrored_supervisor:delete_child(rabbit_shovel_dyn_worker_sup_sup, <<"sh_old1">>)

22:48:18.764772 <0.5627.0> mirrored_supervisor:delete_child/2 --> {error,not_found}

22:48:18.765067 <0.5627.0> mirrored_supervisor:delete_child(rabbit_shovel_dyn_worker_sup_sup, {[<<"gzewjyxk">>,<<"sh_old2">>],{<<"gzewjyxk">>,<<"sh_old2">>}})

22:48:18.765330 <0.5627.0> mirrored_supervisor:delete_child/2 --> {error,not_found}

22:48:18.765617 <0.5627.0> mirrored_supervisor:delete_child(rabbit_shovel_dyn_worker_sup_sup, {[[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}],
 {[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}}})

22:48:18.765911 <0.5627.0> mirrored_supervisor:delete_child/2 --> {error,not_found}

22:48:18.766153 <0.5627.0> mirrored_supervisor:delete_child(rabbit_shovel_dyn_worker_sup_sup, {[[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}],
 {[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}}})

22:48:18.766432 <0.5627.0> mirrored_supervisor:delete_child/2 --> {error,not_found}

22:48:18.766675 <0.5627.0> mirrored_supervisor:delete_child(rabbit_shovel_dyn_worker_sup_sup, <<"sh_old2">>)

22:48:18.767008 <0.5627.0> mirrored_supervisor:delete_child/2 --> {error,not_found}

Clean up sh_old2 worker and status (params are already deleted). Now we have no duplicates

$ rabbitmqctl list_parameters --vhost gzewjyxk
Listing runtime parameters for vhost "gzewjyxk" ...
component	name	value
shovel	sh_old1	{"ack-mode":"on-publish","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q1","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q2","src-uri":"amqp:///gzewjyxk"}
shovel	sh_new1	{"ack-mode":"on-confirm","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q6","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q5","src-uri":"amqp:///gzewjyxk"}

$ rabbitmqctl eval '[element(1, C) || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}},
 {<<"gzewjyxk">>,<<"sh_old1">>}]

$ rabbitmqctl shovel_status
Shovel status on node rabbit@node-01
destination	destination_protocol	destination_queue	last_changed	name	source	source_protocol	source_queue	state	termination_reason	type	vhost
amqp:///gzewjyxk	amqp091	q1	2023-11-21 22:41:26	sh_old1	amqp:///gzewjyxk	amqp091	q2	running		dynamic	gzewjyxk
amqp:///gzewjyxk	amqp091	q6	2023-11-21 22:34:56	sh_new1	amqp:///gzewjyxk	amqp091	q5	running		dynamic	gzewjyxk

Load patch
Restart app on node-01

$ rabbitmqctl stop_app
Stopping rabbit application on node rabbit@node-01 ...
$ rabbitmqctl start_app
Starting node rabbit@node-01 ...

Trace child_exists/1 correctly returns true for old id format as well

> recon_trace:calls({rabbit_shovel_dyn_worker_sup_sup, child_exists, fun(_) -> return_trace(), message(caller()) end}, 20, [{scope,local}]).

22:58:17.158630 <0.7252.0> rabbit_shovel_dyn_worker_sup_sup:child_exists({<<"gzewjyxk">>,<<"sh_old1">>}) {rabbit_shovel_dyn_worker_sup_sup,start_child,2}

22:58:17.164009 <0.7252.0> rabbit_shovel_dyn_worker_sup_sup:child_exists/1 --> true

22:58:17.176158 <0.7252.0> rabbit_shovel_dyn_worker_sup_sup:child_exists({<<"gzewjyxk">>,<<"sh_new1">>}) {rabbit_shovel_dyn_worker_sup_sup,start_child,2}

22:58:17.181636 <0.7252.0> rabbit_shovel_dyn_worker_sup_sup:child_exists/1 --> true

Check cleanup_specs. Does not call delete_child/2 at all

23:4:35.444783 <0.5627.0> rabbit_shovel_dyn_worker_sup_sup:cleanup_specs()

23:4:35.450885 <0.5627.0> rabbit_shovel_dyn_worker_sup_sup:cleanup_specs/0 --> ok

Update old and new shovels (src and dest). Old workers with old args stopped

Update old shovel

$ rabbitmqctl set_parameter --vhost gzewjyxk shovel sh_old1 '{"ack-mode":"on-publish","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q3","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q4","src-uri":"amqp:///gzewjyxk"}'
Setting runtime parameter "sh_old1" for component "shovel" to "{"ack-mode":"on-publish","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q3","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q4","src-uri":"amqp:///gzewjyxk"}" in vhost "gzewjyxk" ...

$ rabbitmqctl eval '[{element(1, C), node(element(2, C))} || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{{[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}},
  'rabbit@node-03'},
 {{[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}},
  'rabbit@node-01'}]

Tracing - stop_child called

23:6:07.097259 <0.8240.0> rabbit_shovel_dyn_worker_sup_sup:child_exists({<<"gzewjyxk">>,<<"sh_old1">>})

23:6:07.103013 <0.8240.0> rabbit_shovel_dyn_worker_sup_sup:child_exists/1 --> true

23:6:07.103300 <0.8240.0> rabbit_shovel_dyn_worker_sup_sup:stop_child({<<"gzewjyxk">>,<<"sh_old1">>})

23:6:07.120443 <0.8240.0> rabbit_shovel_dyn_worker_sup_sup:stop_child/1 --> ok

23:6:07.129323 <0.8240.0> rabbit_shovel_dyn_worker_sup_sup:child_exists({<<"gzewjyxk">>,<<"sh_old1">>})

23:6:07.135079 <0.8240.0> rabbit_shovel_dyn_worker_sup_sup:child_exists/1 --> false

Update new shovel

$ rabbitmqctl set_parameter --vhost gzewjyxk shovel sh_new1 '{"ack-mode":"on-confirm","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q1","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q2","src-uri":"amqp:///gzewjyxk"}'
Setting runtime parameter "sh_new1" for component "shovel" to "{"ack-mode":"on-confirm","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q1","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q2","src-uri":"amqp:///gzewjyxk"}" in vhost "gzewjyxk" ...

$ rabbitmqctl eval '[{element(1, C), node(element(2, C))} || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{{[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}},
  'rabbit@node-01'},
 {{[<<"gzewjyxk">>,<<"sh_old1">>],{<<"gzewjyxk">>,<<"sh_old1">>}},
  'rabbit@node-01'}]

Tracing - stop_child called

23:9:00.249245 <0.8512.0> rabbit_shovel_dyn_worker_sup_sup:child_exists({<<"gzewjyxk">>,<<"sh_new1">>}) {rabbit_shovel_dyn_worker_sup_sup,adjust,2}

23:9:00.255511 <0.8512.0> rabbit_shovel_dyn_worker_sup_sup:child_exists/1 --> true

23:9:00.255812 <0.8512.0> rabbit_shovel_dyn_worker_sup_sup:stop_child({<<"gzewjyxk">>,<<"sh_new1">>})

23:9:00.273702 <0.8512.0> rabbit_shovel_dyn_worker_sup_sup:stop_child/1 --> ok

23:9:00.282851 <0.8512.0> rabbit_shovel_dyn_worker_sup_sup:child_exists({<<"gzewjyxk">>,<<"sh_new1">>}) {rabbit_shovel_dyn_worker_sup_sup,start_child,2}

23:9:00.288935 <0.8512.0> rabbit_shovel_dyn_worker_sup_sup:child_exists/1 --> false

Deleting old and new shovels works

$ rabbitmqctl clear_parameter --vhost gzewjyxk shovel sh_old1
Clearing runtime parameter "sh_old1" for component "shovel" on vhost "gzewjyxk" ...

$ rabbitmqctl eval '[{element(1, C), node(element(2, C))} || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[{{[<<"gzewjyxk">>,<<"sh_new1">>],{<<"gzewjyxk">>,<<"sh_new1">>}},
  'rabbit@node-01'}]

$ rabbitmqctl shovel_status
Shovel status on node rabbit@node-01
destination	destination_protocol	destination_queue	last_changed	name	source	source_protocol	source_queue	state	termination_reason	type	vhost
amqp:///gzewjyxk	amqp091	q1	2023-11-21 23:09:00	sh_new1	amqp:///gzewjyxk	amqp091	q2	running		dynamic	gzewjyxk

$ rabbitmqctl list_parameters --vhost gzewjyxk
Listing runtime parameters for vhost "gzewjyxk" ...
component	name	value
shovel	sh_new1	{"ack-mode":"on-confirm","dest-add-forward-headers":false,"dest-protocol":"amqp091","dest-queue":"q1","dest-uri":"amqp:///gzewjyxk","src-delete-after":"never","src-protocol":"amqp091","src-queue":"q2","src-uri":"amqp:///gzewjyxk"}

$ rabbitmqctl clear_parameter --vhost gzewjyxk shovel sh_new1
Clearing runtime parameter "sh_new1" for component "shovel" on vhost "gzewjyxk" ...

$ rabbitmqctl eval '[{element(1, C), node(element(2, C))} || C <- mirrored_supervisor:which_children(rabbit_shovel_dyn_worker_sup_sup)].'
[]

$ rabbitmqctl shovel_status
Shovel status on node rabbit@node-01

$ rabbitmqctl list_parameters --vhost gzewjyxk
Listing runtime parameters for vhost "gzewjyxk" ...

michaelklishin added this to the 3.12.10 milestone Nov 22, 2023

michaelklishin merged commit 1f61ca8 into rabbitmq:v3.12.x Nov 22, 2023

gomoripeti mentioned this pull request Nov 28, 2023

Fix handling shovels with old supervisor id format #10004

Merged

12 tasks

gomoripeti mentioned this pull request Dec 8, 2023

Dynamic Shovels: support old and new supervisor child ID formats on 3.11.x #10080

Merged

12 tasks

michaelklishin mentioned this pull request Jan 10, 2024

Exchange federation link worker sup IDs not handled properly after upgrade to 3.13 #10306

Closed

dumbbell mentioned this pull request Feb 8, 2024

Rework mirrored_supervisor child ID format #10472

Merged

gomoripeti deleted the fix_dup_shovel branch February 12, 2024 12:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix dyn shovel child_exists check for old id format #9968

Fix dyn shovel child_exists check for old id format #9968

Uh oh!

gomoripeti commented Nov 21, 2023

Uh oh!

gomoripeti commented Nov 22, 2023

Uh oh!

Uh oh!

Fix dyn shovel child_exists check for old id format #9968

Fix dyn shovel child_exists check for old id format #9968

Uh oh!

Conversation

gomoripeti commented Nov 21, 2023

Proposed Changes

Types of Changes

Checklist

Further Comments

Uh oh!

gomoripeti commented Nov 22, 2023

Uh oh!

Uh oh!