Skip to content

Commit 90a6752

Browse files
authored
Increase the timeout for confirmation to 10s (#325)
* Increase the timeout for publish confirmation to 10s * 3s was too aggressive. ---- Signed-off-by: Gabriele Santomaggio <[email protected]>
1 parent cd46117 commit 90a6752

File tree

6 files changed

+9
-7
lines changed

6 files changed

+9
-7
lines changed

RabbitMQ.Stream.Client/Reliable/Producer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public record SuperStreamConfig
2222

2323
public record ProducerConfig : ReliableConfig
2424
{
25-
private readonly TimeSpan _timeoutMessageAfter = TimeSpan.FromSeconds(3);
25+
private readonly TimeSpan _timeoutMessageAfter = TimeSpan.FromSeconds(10);
2626

2727
/// <summary>
2828
/// Reference used for deduplication.

Tests/ClientTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ await client.Publish(new Publish(publisherId,
332332

333333
Assert.Equal(10, messageCount);
334334
await client.Unsubscribe(subId);
335-
// await client.Close("done");
335+
await client.Close("done");
336336
}
337337

338338
[Fact]
@@ -422,6 +422,6 @@ public async void ExchangeVersionCommandsShouldNotBeEmpty()
422422
Assert.Equal(ResponseCode.Ok, response.ResponseCode);
423423
Assert.True(response.Commands.Count > 0);
424424
await client.Close("done");
425-
}
425+
}
426426
}
427427
}

Tests/MultiThreadTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ public async Task PublishMessagesInMultiThreads()
7979
Assert.Equal(TotalMessages * ThreadNumber, confirmed);
8080
Assert.Equal(TotalMessages * ThreadNumber, receivedTask.Task.Result);
8181
Assert.Equal(0, error);
82-
await system.DeleteStream(stream);
82+
await producer.Close().ConfigureAwait(false);
83+
await SystemUtils.CleanUpStreamSystem(system, stream);
8384
}
8485

8586
[Fact]
@@ -128,7 +129,6 @@ public async Task CloseProducersConsumersInMultiThreads()
128129

129130
SystemUtils.WaitUntil(() => consumers.TrueForAll(c => !c.IsOpen()));
130131
Assert.All(consumers, c => Assert.False(c.IsOpen()));
131-
await system.DeleteStream(stream);
132-
await system.Close();
132+
await SystemUtils.CleanUpStreamSystem(system, stream);
133133
}
134134
}

Tests/ReliableTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ public async void SendMessageAfterKillConnectionShouldContinueToWork()
155155
new ProducerConfig(system, stream)
156156
{
157157
ClientProvidedName = clientProvidedName,
158+
TimeoutMessageAfter = TimeSpan.FromSeconds(3),
158159
ConfirmationHandler = _ =>
159160
{
160161
if (Interlocked.Increment(ref count) == 10)

Tests/SuperStreamConsumerTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ public async void MoreConsumersNumberOfMessagesConsumedShouldBeEqualsToPublished
211211
var system = await StreamSystem.Create(new StreamSystemConfig());
212212
var publishToSuperStreamTask =
213213
SystemUtils.PublishMessagesSuperStream(system, "invoices", NumberOfMessages, "", _testOutputHelper);
214-
if (await Task.WhenAny(publishToSuperStreamTask, Task.Delay(10000)) != publishToSuperStreamTask)
214+
if (await Task.WhenAny(publishToSuperStreamTask, Task.Delay(20000)) != publishToSuperStreamTask)
215215
{
216216
Assert.Fail("timeout waiting to publish messages");
217217
}

Tests/SystemTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,7 @@ public async void NumberOfPartitionsShouldBeAsDefinition()
319319
Assert.Contains(SystemUtils.InvoicesStream1, partitions);
320320
Assert.Contains(SystemUtils.InvoicesStream2, partitions);
321321
Assert.DoesNotContain(SystemUtils.InvoicesExchange, partitions);
322+
await system.Close().ConfigureAwait(false);
322323
}
323324
}
324325
}

0 commit comments

Comments
 (0)