Skip to content

Increase the timeout for confirmation to 10s #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Oct 26, 2023

  • Increasing the publish confirmation from 3s to 10s.
    3s was too aggressive.

  • Increase some timeout to handle the not-confirmed messages

cc @michaelklishin @Zerpet

3s was too aggressive.

Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio marked this pull request as draft October 26, 2023 11:10
3s was too aggressive

Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio added this to the 1.7.4 milestone Oct 26, 2023
Signed-off-by: Gabriele Santomaggio <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a515ea9) 92.66% compared to head (1935269) 92.65%.
Report is 1 commits behind head on main.

❗ Current head 1935269 differs from pull request most recent head caf27b4. Consider uploading reports for the commit caf27b4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   92.66%   92.65%   -0.01%     
==========================================
  Files         113      113              
  Lines        9961     9964       +3     
  Branches      825      825              
==========================================
+ Hits         9230     9232       +2     
  Misses        555      555              
- Partials      176      177       +1     
Files Coverage Δ
RabbitMQ.Stream.Client/Reliable/Producer.cs 83.43% <100.00%> (-0.60%) ⬇️
Tests/ClientTests.cs 97.43% <100.00%> (+<0.01%) ⬆️
Tests/MultiThreadTests.cs 100.00% <100.00%> (ø)
Tests/ReliableTests.cs 99.24% <100.00%> (+<0.01%) ⬆️
Tests/SystemTests.cs 100.00% <100.00%> (ø)
Tests/SuperStreamConsumerTests.cs 94.24% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gsantomaggio Gsantomaggio marked this pull request as ready for review October 26, 2023 12:58
@Gsantomaggio Gsantomaggio requested a review from Zerpet October 26, 2023 12:59
@Gsantomaggio Gsantomaggio merged commit 90a6752 into main Oct 30, 2023
@Gsantomaggio Gsantomaggio deleted the bump_confirm_timeout branch October 30, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant