Skip to content

Max segment size #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Conversation

simone-fariselli
Copy link
Contributor

added configuration for MaxSegmentSizeBytes (issue #105)

@codecov-commenter
Copy link

Codecov Report

Merging #110 (061cf03) into main (705daa7) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   91.25%   91.46%   +0.21%     
==========================================
  Files          69       69              
  Lines        4743     4755      +12     
  Branches      276      276              
==========================================
+ Hits         4328     4349      +21     
+ Misses        353      345       -8     
+ Partials       62       61       -1     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/StreamSpec.cs 100.00% <100.00%> (ø)
Tests/SystemTests.cs 100.00% <100.00%> (ø)
Tests/ClientTests.cs 97.29% <0.00%> (+1.35%) ⬆️
RabbitMQ.Stream.Client/WireFormatting.cs 78.41% <0.00%> (+3.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705daa7...061cf03. Read the comment docs.

Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can you please add the documentation to the README.md section (manage stream)?

@Gsantomaggio Gsantomaggio self-assigned this Apr 28, 2022
@Gsantomaggio Gsantomaggio merged commit 950eaab into rabbitmq:main Apr 28, 2022
@Gsantomaggio Gsantomaggio deleted the max_segment_size branch April 28, 2022 14:52
@Gsantomaggio
Copy link
Member

Thank you @simone-fariselli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants