Skip to content

Support External SASL configuration #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Support External SASL configuration #274

merged 4 commits into from
Jun 13, 2023

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Jun 7, 2023

Support External SALS Auth

How to test:

var ssl = new SslOption()
        {
            Enabled = true,
            ServerName = "my_server_name",
            CertPath = "certs/client/keycert.p12",
            CertPassphrase = null,
            CertificateValidationCallback = (sender, certificate, chain, errors) => true,
        };

        var config = new StreamSystemConfig()
        {
            UserName = "user_does_not_exist",
            Password = "password_does_not_exist",
            Ssl = ssl,
            Endpoints = new List<EndPoint>(new List<EndPoint>()
            {
                new DnsEndPoint("my_server_name", 5551)
            }),

            AuthMechanism = AuthMechanism.External,
        };
        const string stream = "test-stream";
        var system = await StreamSystem.Create(config);
        await system.CreateStream(new StreamSpec(stream));
        Console.WriteLine("Stream created");

Docker image:

pivotalrabbitmq/rabbitmq:v3.12.x-otp-max-bazel

or server version for this fix rabbitmq/rabbitmq-server#8488

Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio added this to the 1.5.0 milestone Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: -0.15 ⚠️

Comparison is base (a209be3) 93.09% compared to head (437d6b5) 92.94%.

❗ Current head 437d6b5 differs from pull request most recent head 2746a9f. Consider uploading reports for the commit 2746a9f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   93.09%   92.94%   -0.15%     
==========================================
  Files         104      104              
  Lines        9120     9139      +19     
  Branches      720      722       +2     
==========================================
+ Hits         8490     8494       +4     
- Misses        484      497      +13     
- Partials      146      148       +2     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/StreamSystem.cs 83.07% <70.00%> (-0.13%) ⬇️
RabbitMQ.Stream.Client/Client.cs 92.18% <100.00%> (+0.14%) ⬆️
RabbitMQ.Stream.Client/ClientExceptions.cs 70.73% <100.00%> (+2.31%) ⬆️
RabbitMQ.Stream.Client/RawConsumer.cs 85.67% <100.00%> (-0.09%) ⬇️
Tests/SystemTests.cs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gsantomaggio Gsantomaggio marked this pull request as ready for review June 8, 2023 14:04
@Gsantomaggio Gsantomaggio requested a review from lukebakken June 8, 2023 14:04
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio merged commit b6fa21e into main Jun 13, 2023
@Gsantomaggio Gsantomaggio deleted the sasl_configuration branch June 13, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant