Skip to content

Removed unused class MyMethodAttribute from Producer.cs #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

TroelsL
Copy link
Contributor

@TroelsL TroelsL commented Sep 22, 2023

Found an unused internal class in Producer.cs. Unless there is a future use for this, it is not needed. But the naming seems to indicate that this was test code.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (20a43f3) 92.65% compared to head (94d2f20) 92.65%.

❗ Current head 94d2f20 differs from pull request most recent head 02b0571. Consider uploading reports for the commit 02b0571 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   92.65%   92.65%   -0.01%     
==========================================
  Files         112      112              
  Lines        9795     9791       -4     
  Branches      786      786              
==========================================
- Hits         9076     9072       -4     
  Misses        547      547              
  Partials      172      172              
Files Changed Coverage Δ
RabbitMQ.Stream.Client/Reliable/Producer.cs 83.33% <ø> (+1.93%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Gsantomaggio Gsantomaggio merged commit 6ddbf98 into rabbitmq:main Sep 23, 2023
@TroelsL TroelsL deleted the remove_mymethod_attribute branch September 23, 2023 19:34
@Gsantomaggio Gsantomaggio modified the milestones: 1.7.1, 1.7.2 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants