Skip to content

Make the info class abstract #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Make the info class abstract #323

merged 1 commit into from
Oct 11, 2023

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Oct 11, 2023

Per conversation with @Zerpet

it is better to have info class for each type so we can specialize them adding more info about Producer or Consumer

Signed-off-by: Gabriele Santomaggio <[email protected]>
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e37f2a2) 92.65% compared to head (3370a4b) 92.60%.

❗ Current head 3370a4b differs from pull request most recent head b20e36c. Consider uploading reports for the commit b20e36c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   92.65%   92.60%   -0.06%     
==========================================
  Files         113      113              
  Lines        9963     9961       -2     
  Branches      825      825              
==========================================
- Hits         9231     9224       -7     
- Misses        555      560       +5     
  Partials      177      177              
Files Coverage Δ
RabbitMQ.Stream.Client/AbstractEntity.cs 100.00% <ø> (ø)
RabbitMQ.Stream.Client/EntityInfo.cs 100.00% <100.00%> (ø)
RabbitMQ.Stream.Client/IConsumer.cs 100.00% <100.00%> (ø)
RabbitMQ.Stream.Client/IProducer.cs 100.00% <100.00%> (ø)
RabbitMQ.Stream.Client/RawConsumer.cs 84.36% <100.00%> (ø)
RabbitMQ.Stream.Client/RawProducer.cs 88.35% <100.00%> (ø)
RabbitMQ.Stream.Client/RawSuperStreamConsumer.cs 94.30% <100.00%> (ø)
RabbitMQ.Stream.Client/RawSuperStreamProducer.cs 96.72% <100.00%> (ø)
RabbitMQ.Stream.Client/Reliable/Consumer.cs 100.00% <100.00%> (ø)
...MQ.Stream.Client/Reliable/DeduplicatingProducer.cs 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gsantomaggio Gsantomaggio marked this pull request as ready for review October 11, 2023 13:19
@Gsantomaggio Gsantomaggio merged commit a515ea9 into main Oct 11, 2023
@Gsantomaggio Gsantomaggio deleted the make_info_abstract branch October 11, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants