Skip to content

Support encrypting binary columns #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024
Merged

Support encrypting binary columns #1178

merged 1 commit into from
May 17, 2024

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented May 17, 2024

Fix ActiveRecord::Encryption::EncryptableRecordTest#test_0049_serialized binary data can be encrypted.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9116557246/job/25065421824

 13) Error:
ActiveRecord::Encryption::EncryptableRecordTest#test_0049_serialized binary data can be encrypted:
ActiveRecord::StatementInvalid: TinyTds::Error: Implicit conversion from data type nvarchar(max) to varbinary(max) is not allowed. Use the CONVERT function to run this query.
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:434:in `each'

Ref: rails/rails#50920

@aidanharan aidanharan marked this pull request as ready for review May 17, 2024 10:50
@aidanharan aidanharan merged commit af26fc9 into main May 17, 2024
2 of 8 checks passed
@aidanharan aidanharan deleted the encrypted-attribute branch May 17, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant