Skip to content

Updated coerced test #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2024
Merged

Updated coerced test #1185

merged 1 commit into from
May 21, 2024

Conversation

aidanharan
Copy link
Contributor

Updated QueryCacheExpiryTest#test_insert_all_coerced test to reflect changes made to Rails original version.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9158512181/job/25177030073

  5) Failure:
QueryCacheExpiryTest#test_insert_all_coerced [test/cases/coerced_tests.rb:2200]:
Expected clear_query_cache to be called 2 times, but was called 0 times.
Expected: 2
  Actual: 0

@aidanharan aidanharan changed the title Updated test to match Rails original Fix QueryCacheExpiryTest#test_insert_all_coerced test May 21, 2024
@aidanharan aidanharan changed the title Fix QueryCacheExpiryTest#test_insert_all_coerced test Updated coerced test May 21, 2024
@aidanharan aidanharan marked this pull request as ready for review May 21, 2024 09:18
@aidanharan aidanharan merged commit 204bc98 into main May 21, 2024
2 of 8 checks passed
@aidanharan aidanharan deleted the fix-insert-all-test branch May 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan