Keep ordering in count subquery #1227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the ordering in the count subquery.
Before PR the query generated by
accounts.count(:firm_id)
inCalculationsTest#test_order_should_apply_before_count
was:It should be (
DESC
instead ofASC
):Fixes test:
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/11072699849/job/30767524773