Skip to content

Exist queries are retryable #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Exist queries are retryable #1294

merged 1 commit into from
Feb 10, 2025

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Feb 10, 2025

Fix following tests:

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/13201053254/job/36852898476

  4) Failure:
ActiveRecord::AdapterConnectionTest#test_0015_idempotent SELECT queries allow retries [/usr/local/bundle/bundler/gems/rails-cd4708bbcd0d/activerecord/test/cases/adapter_test.rb:716]:
Expected false to be truthy.

Skipped:
ActiveRecord::AdapterConnectionTest#test_0015_idempotent SELECT queries allow retries [/usr/local/bundle/bundler/gems/rails-cd4708bbcd0d/activerecord/test/cases/adapter_test.rb:716]:
kill_connection_from_server unsupported

  5) Failure:
ActiveRecord::AdapterConnectionTest#test_0016_query cacheable idempotent SELECT queries allow retries [/usr/local/bundle/bundler/gems/rails-cd4708bbcd0d/activerecord/test/cases/adapter_test.rb:735]:
EXEC sp_executesql N'SELECT 1 AS one FROM [posts] ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @0 ROWS ONLY', N'@0 int', @0 = 1 was not retryable

Skipped:
ActiveRecord::AdapterConnectionTest#test_0016_query cacheable idempotent SELECT queries allow retries [/usr/local/bundle/bundler/gems/rails-cd4708bbcd0d/activerecord/test/cases/adapter_test.rb:735]:
kill_connection_from_server unsupported

Ref: rails/rails#54436

@aidanharan aidanharan marked this pull request as ready for review February 10, 2025 15:02
@aidanharan aidanharan merged commit b26d642 into main Feb 10, 2025
2 of 5 checks passed
@aidanharan aidanharan deleted the retryable-queries branch February 10, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant