Relax version requirement and test against Rails master (6.0.0.alpha) #42
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
sikachu
changed the title
sikachu
changed the title
rails-controller-testing.gemspec
Outdated
| s.add_dependency "actionpack", "~> 5.x", ">= 5.0.1" | ||
| s.add_dependency "actionview", "~> 5.x", ">= 5.0.1" | ||
| s.add_dependency "activesupport", "~> 5.x" | ||
| s.add_dependency "actionpack", ">= 5.0.1", "< 6.1.x" |
There was a problem hiding this comment.
Is there a reason we need "< 6.1.x"?
There was a problem hiding this comment.
@composerinteralia I think being a bit conservative is good, since we don't know the future.
This will make the gem compatible up to 6.1.0.rc* but not 6.1.0 final. By the point that 6.1.0.alpha starts, I think we will already have another patch ready to bump it to, say, < 6.2.x, depends on how Rails core team decide on what's the next version should be.
I'm trying to fix a compatibility issue with rspec-rails, and looks like right now they can't even point to rails master since
rails-controller-testingrequirement does not support prerelease version.