CI: Use rails as git gem with branch 5-2-stable in Gemfile-rails-5-2 to support Ruby 2.2.10 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
changed the title
olleolleolle
force-pushed
the
build-on-2-2-10
branch
from
a1729ca to
3e93a31
Compare
kaspth
reviewed
Mar 26, 2020
olleolleolle
force-pushed
the
build-on-2-2-10
branch
from
3e93a31 to
86a0deb
Compare
olleolleolle
force-pushed
the
build-on-2-2-10
branch
from
86a0deb to
4f21f70
Compare
|
@kaspth Thanks for taking a look! I changed from |
|
Thank you ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build (for Rails 5.2 with Ruby 2.2).
2.2.10 does not have safe navigation which is used in the published 5.2 gems.
Background
Example error message:
Using the safe-navigation-free
5-2-stablebranch from git fixes it.Rafael taught me this, in another repo. Thanks for that!
Solution