Skip to content

autoload + immediately load => require #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2020
Merged

autoload + immediately load => require #89

merged 1 commit into from
Nov 25, 2020

Conversation

amatsuda
Copy link
Member

dom/testing/assertions.rb autoloads two constants, then immediately references these two constants a couple lines below the autoload.
It'd be better to simply require these files.

kaspth
kaspth approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@kaspth kaspth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure sure, I think I just reused the pattern from ActiveRecord::Base and elsewhere in Rails, although my memory is fussy 👍

@amatsuda amatsuda merged commit 1cfcd00 into rails:master Nov 25, 2020
@amatsuda amatsuda deleted the manuaload branch November 25, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspth kaspth kaspth approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amatsuda @kaspth