Skip to content

Commit 6594807

Browse files
committed
Merge pull request #339 from Andreis13/sprockets-4
Sass-rails on Sprockets 4.
2 parents 8e68c5f + 26eb5e8 commit 6594807

25 files changed

+23
-208
lines changed

.travis.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,13 @@
11
language: ruby
22

33
rvm:
4-
- 1.9.3
54
- 2.0.0
65
- 2.1
76
- 2.2
87
- rbx-2
98

109
gemfile:
11-
- gemfiles/Gemfile-rails-4-0
12-
- gemfiles/Gemfile-rails-4-1
1310
- gemfiles/Gemfile-rails-4-2
14-
- gemfiles/Gemfile-sprockets-2-11
15-
- gemfiles/Gemfile-sprockets-2-12
16-
- gemfiles/Gemfile-sprockets-2-8
17-
- gemfiles/Gemfile-sprockets-3-0
18-
- gemfiles/Gemfile-sprockets-rails-2-2
19-
- gemfiles/Gemfile-sprockets-rails-master
20-
- gemfiles/Gemfile-sass-3-1
21-
- gemfiles/Gemfile-sass-3-2
2211
- gemfiles/Gemfile-sass-3-3
2312
- gemfiles/Gemfile-sass-3-4
2413

Gemfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,5 @@ gemspec
55

66
gem "rails", github: "rails/rails"
77
gem "arel", github: "rails/arel"
8+
gem "sprockets", github: "rails/sprockets", branch: "master"
9+
gem "sprockets-rails", github: "rails/sprockets-rails", branch: "master"

gemfiles/Gemfile-rails-4-0

Lines changed: 0 additions & 6 deletions
This file was deleted.

gemfiles/Gemfile-rails-4-1

Lines changed: 0 additions & 6 deletions
This file was deleted.

gemfiles/Gemfile-rails-4-2

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,5 @@ source "https://rubygems.org"
44
gemspec path: ".."
55

66
gem "rails", "~> 4.2.0"
7+
gem "sprockets", github: "rails/sprockets", branch: "master"
8+
gem "sprockets-rails", github: "rails/sprockets-rails", branch: "master"

gemfiles/Gemfile-sass-3-1

Lines changed: 0 additions & 7 deletions
This file was deleted.

gemfiles/Gemfile-sass-3-2

Lines changed: 0 additions & 7 deletions
This file was deleted.

gemfiles/Gemfile-sass-3-3

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,5 @@ gemspec path: ".."
55

66
gem "rails"
77
gem "sass", "~> 3.3.0"
8+
gem "sprockets", github: "rails/sprockets", branch: "master"
9+
gem "sprockets-rails", github: "rails/sprockets-rails", branch: "master"

gemfiles/Gemfile-sass-3-4

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,5 @@ gemspec path: ".."
55

66
gem "rails"
77
gem "sass", "~> 3.4.0"
8+
gem "sprockets", github: "rails/sprockets", branch: "master"
9+
gem "sprockets-rails", github: "rails/sprockets-rails", branch: "master"

gemfiles/Gemfile-sprockets-2-11

Lines changed: 0 additions & 7 deletions
This file was deleted.

gemfiles/Gemfile-sprockets-2-12

Lines changed: 0 additions & 7 deletions
This file was deleted.

gemfiles/Gemfile-sprockets-2-8

Lines changed: 0 additions & 7 deletions
This file was deleted.

gemfiles/Gemfile-sprockets-3-0

Lines changed: 0 additions & 7 deletions
This file was deleted.

gemfiles/Gemfile-sprockets-rails-2-2

Lines changed: 0 additions & 7 deletions
This file was deleted.

gemfiles/Gemfile-sprockets-rails-master

Lines changed: 0 additions & 7 deletions
This file was deleted.

lib/sass/rails.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,5 @@ module Rails
55
end
66

77
require 'sass/rails/version'
8-
require 'sass/rails/helpers'
98
require 'sass/rails/importer'
10-
require 'sass/rails/template'
119
require 'sass/rails/railtie'

lib/sass/rails/cache_store.rb

Lines changed: 0 additions & 31 deletions
This file was deleted.

lib/sass/rails/helpers.rb

Lines changed: 0 additions & 12 deletions
This file was deleted.

lib/sass/rails/importer.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
require 'active_support/deprecation/reporting'
2-
require 'sass'
32
require 'sprockets/sass_importer'
43
require 'tilt'
54

65
module Sass
76
module Rails
8-
class SassImporter < Sass::Importers::Filesystem
7+
class SassImporter < Sprockets::SassImporter
98
module Globbing
109
GLOB = /(\A|\/)(\*|\*\*\/\*)\z/
1110

lib/sass/rails/railtie.rb

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
require 'sass'
22
require 'active_support/core_ext/class/attribute'
33
require 'sprockets/railtie'
4+
require 'sprockets/sass_processor'
45

56
module Sass::Rails
67
class Railtie < ::Rails::Railtie
@@ -54,8 +55,11 @@ class Railtie < ::Rails::Railtie
5455
end
5556

5657
config.assets.configure do |env|
57-
env.register_engine '.sass', Sass::Rails::SassTemplate
58-
env.register_engine '.scss', Sass::Rails::ScssTemplate
58+
59+
env.register_transformer 'text/sass', 'text/css',
60+
Sprockets::SassProcessor.new(importer: SassImporter)
61+
env.register_transformer 'text/scss', 'text/css',
62+
Sprockets::ScssProcessor.new(importer: SassImporter)
5963

6064
env.context_class.class_eval do
6165
class_attribute :sass_config

lib/sass/rails/template.rb

Lines changed: 0 additions & 72 deletions
This file was deleted.

lib/sass/rails/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
module Sass
22
module Rails
3-
VERSION = "5.0.3"
3+
VERSION = "6.0.0"
44
end
55
end

sass-rails.gemspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ Gem::Specification.new do |s|
1414
s.license = %q{MIT}
1515

1616
s.add_dependency 'railties', '>= 4.0.0', '< 5.0'
17-
s.add_dependency 'sass', '~> 3.1'
18-
s.add_dependency 'sprockets-rails', '>= 2.0', '< 4.0'
19-
s.add_dependency 'sprockets', '>= 2.8', '< 4.0'
17+
s.add_dependency 'sass', '~> 3.3'
18+
s.add_dependency 'sprockets-rails', '>= 3.0', '< 4.0'
19+
s.add_dependency 'sprockets', '>= 4.0'
2020
s.add_dependency 'tilt', '>= 1.1', '< 3'
2121

2222
s.add_development_dependency 'sqlite3'
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Rails.application.config.assets.configure do |env|
2-
env.register_postprocessor 'text/css', :postprocessor do |context, css|
3-
css.gsub /@import/, 'fail engine'
2+
env.register_postprocessor 'text/css' do |input|
3+
input[:data].gsub /@import/, 'fail engine'
44
end
55
end

test/sass_rails_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ class SassRailsTest < Sass::Rails::TestCase
134134

135135
test 'globbed imports work when new file is added' do
136136
project = 'scss_project'
137-
filename = 'application.scss'
137+
filename = 'application.css'
138138

139139
within_rails_app(project) do |tmpdir|
140140
asset_output(filename)
@@ -151,7 +151,7 @@ class SassRailsTest < Sass::Rails::TestCase
151151

152152
test 'globbed imports work when globbed file is changed' do
153153
project = 'scss_project'
154-
filename = 'application.scss'
154+
filename = 'application.css'
155155

156156
within_rails_app(project) do |tmpdir|
157157
asset_output(filename)

0 commit comments

Comments
 (0)