Skip to content

Sass-rails on Sprockets 4. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2015
Merged

Conversation

Andreis13
Copy link
Contributor

No description provided.


module Sass
module Rails
class CacheStore < ::Sass::CacheStores::Base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using the default cache store right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@malida
Copy link

malida commented Jul 16, 2015

Sorry I haven't spoken up earlier, but Andreis13's work affects work toward supporting Sassc instead of the Sass ruby gem. Since there won’t be any template.rb file I think my changes should be applied to sprockets directly, specifically the sass_processor.rb file. Is that correct? If not, where is the new canonical location for this kind of support? I'm unsure whether to put this stuff in sprockets or sass-rails.

@rafaelfranca
Copy link
Member

@malida I think we should move everything that is not Rails specific to sprockets and keep this project just to integrate things with Rails.

Instead of changing the SassProcess directly I think it is better to investigate a new processor that will deal with sassc, but if the code is too similar an option for the processor like we did with the importer on this PR would also work.

Does it sounds a good plan?

@malida
Copy link

malida commented Jul 17, 2015

It sounds great! Thanks.

rafaelfranca added a commit that referenced this pull request Jul 22, 2015
@rafaelfranca rafaelfranca merged commit 6594807 into rails:master Jul 22, 2015
@Andreis13 Andreis13 deleted the sprockets-4 branch July 29, 2015 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants