Only access environment directly in configure block #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This changes the exception raised from But at least we have the expected constant registered on the |
josh
added a commit
that referenced
this pull request
Mar 23, 2015
Only access environment directly in configure block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix some issues mentioned by @rafaelfranca and @lucasmazza over on rails/sprockets#10 (comment).
This should work even on really old sprockets-rails versions. Might want to get this backported to the
4-0-stablebranch here.Kinda wanted to add some test matrix coverage here to try to show this fails and fixes the issue on newer sprockets-rails versions.