[ci skip] Correct docs for asset helpers #342
Conversation
| @@ -68,24 +68,24 @@ in Sass): | |||
| #### `asset-path($relative-asset-path)` | |||
| Returns a string to the asset. | |||
|
|
|||
| * `asset-path("rails.png")` becomes `"/assets/rails.png"` | |||
There was a problem hiding this comment.
The idea of this line is to tell that the call of asset-path("rails.png") will generate that string. So maybe we should change becomes with something else.
There was a problem hiding this comment.
Maybe something like is output as ? I suggested the change because I mis-understood "becomes" when I converted one of my rails projects to use the asset pipeline.
There was a problem hiding this comment.
Maybe returns would be better for this case since we are talking about the method?
There was a problem hiding this comment.
Yes, returns sounds good to me.
There was a problem hiding this comment.
Cool! Could you update the patch?
There was a problem hiding this comment.
I just did. Do you think I should also update this from my PR rails/rails#21143 for the Rails Asset Pipeline guide? Readers might be confused otherwise.
|
Thank you for the PR. |
[ci skip] Correct docs for asset helpers
[ci skip] Correct docs for asset helpers
The instructions for asset helpers were reversed, so the docs told you to replace the new expression ('image-url') with the old one ('url') instead of the other way around.