Skip to content

Docs: Add notes for running tailwindcss:watch in Docker #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2022

Conversation

geetfun
Copy link
Contributor

@geetfun geetfun commented May 3, 2022

While running bin/rails tailwindcss:watch from within a Procfile, it was noticed that the command returns an exit 0 status if this is happening from within a Docker container.

See tailwindlabs/tailwindcss#5324 for same problem and solution.

This may present as a gotcha for those running their Rails app from docker-compose.yml. Suggestion here to add this useful piece of information in the README.

@paddy-hack
Copy link

Ran into this myself and found the same issue you mentioned 😅

Copy link
Contributor

@dixpac dixpac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful 👍🏼 . But, maybe we don't need new sub-heading for this can we just add note about docker in the beginning where tailwindcss:watch is mentioned.

Somewhere around this paragraph:

When you're developing your application, you want to run Tailwind in watch mode, so changes are automatically reflected in the generated CSS output. You can do this either by running rails tailwindcss:watch as a separate process, or by running ./bin/dev which uses foreman to starts both the Tailwind watch process and the rails server in development mode.

@geetfun
Copy link
Contributor Author

geetfun commented May 11, 2022

This is helpful 👍🏼 . But, maybe we don't need new sub-heading for this can we just add note about docker in the beginning where tailwindcss:watch is mentioned.

Good idea. I've moved it to your suggested paragraph where rails tailwindcss:watch is mentioned.

@dhh dhh merged commit c96247a into rails:main May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants