Modules: Convert SSL default option to Boolean in several modules #20298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick search through the library code reveals several instances (before I stopped looking) where using a string literal may result in unexpected behavior, as a value of
'False'
or'false'
evaluates totrue
. I'm not sure if these code paths would be hit by the affected modules (because I didn't look); regardless, we should be consistent with other modules.metasploit-framework/lib/msf/core/exploit/format/webarchive.rb
Line 331 in b6ed7f0
metasploit-framework/lib/msf/core/exploit/remote/browser_autopwn2.rb
Line 554 in b6ed7f0
metasploit-framework/lib/msf/core/exploit/remote/winrm.rb
Lines 62 to 63 in b6ed7f0
metasploit-framework/lib/msf/core/exploit/remote/http_server.rb
Lines 440 to 441 in b6ed7f0